[3.4] Android: Only warn when Target SDK is non default #62609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
commented
Jul 1, 2022
akien-mga
force-pushed
the
3.4-android-preset-target-sdk-warning
branch
from
8ddcb46
to
5fa6b90
Compare
|
I updated this PR to use Edit: Wait, the warning system doesn't work in Edit 2: Backported relevant part of #51550 that added support for displaying warnings.
|
The validation logic for Min Sdk and Target Sdk was flawed as it triggers errors for users not using Custom Build even if they never modified the values themselves. The default values for those settings get saved in `export_presets.cfg` and thus the error gets triggered when moving from 3.4.4 or earlier to 3.4.5, as the target SDK changed from 30 to 31. So instead we just show a warning to make users aware of this non-default Min Sdk or mostly Target Sdk that might be in their preset. We also warn when they do use Custom Build as the target SDK 30 would likely still be an upgrade issue and not an intentional choice, especially given that Google Play will now require SDK 31. The export info dialog is now exclusive so that when it doesn't auto-close, i.e. when it errors, you don't close it by mistake by clicking outside. The valid range for both options is no longer limited to Godot's own default target SDK, but can accept higher values (they are not guaranteed to work, but they might). To be able to display warning, the relevant code is backported from 30ee208. Fixes godotengine#62465 without breaking compatibility for 3.4.5.
akien-mga
force-pushed
the
3.4-android-preset-target-sdk-warning
branch
from
5fa6b90
to
431558d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation logic for Min Sdk and Target Sdk was flawed as it triggers
errors for users not using Custom Build even if they never modified the
values themselves.
The default values for those settings get saved in
export_presets.cfgandthus the error gets triggered when moving from 3.4.4 or earlier to 3.4.5, as
the target SDK changed from 30 to 31.
So instead we just raise a warning to make users aware of this non-default
Min Sdk or mostly Target Sdk that might be in their preset.
We also warn when they do use Custom Build as the target SDK 30 would likely
still be an upgrade issue and not an intentional choice, especially given
that Google Play will now require SDK 31.
The export info dialog is now exclusive so that when it doesn't auto-close,
i.e. when it errors, you don't close it by mistake by clicking outside.
The valid range for both options is no longer limited to Godot's own default
target SDK, but can accept higher values (they are not guaranteed to work,
but they might).